Convert INTSXP Dates to REALSXP Dates#953
Closed
RasmusSkytte wants to merge 4 commits intor-dbi:mainfrom
Closed
Conversation
Dates can sometimes be internally represented as integers (INTSXP) or floating point (REALSXP). Dates created via `seq.Date()` or `as.Date(...L)` uses the INTSXP representation which introduces errors when interfacing with some SQL backends (e.g. SQL Server)
Co-authored-by: Rasmus Skytte Eriksen <[email protected]>
date/time: handle r types with integer storage
This reverts commit d0f7d9e.
Collaborator
|
Closing in favor of #954! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #952
Dates can internally be represented as integers (INTSXP) or floating point (REALSXP).
If INTSXP Dates are being copied to SQL Server the error "Restricted data type attribute violation" is thrown (at least in some configurations).
This PR converts the Integer Dates to numeric Dates via
sqlData()