Oracle: date/time: Fix writing of mismatched c/sql type.#963
Merged
detule merged 4 commits intor-dbi:mainfrom Dec 1, 2025
Merged
Oracle: date/time: Fix writing of mismatched c/sql type.#963detule merged 4 commits intor-dbi:mainfrom
detule merged 4 commits intor-dbi:mainfrom
Conversation
Both the Simba as well as the OEM driver map the Oracle "DATE" datatype, to SQL_TYPE_TIMESTAMP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is more information in #959. The condensed story is:
Oracle::DATEtargets, for example.SQLBindParametersAPI call has two types (target parameter SQL type, and buffer C type), and two buffer sizes (target parameter size, and buffer size). It is important that these are specified correctly since it seems some drivers are more flexible than others (if we correctly specify the c type, the buffer length is inferred correctly in some cases, and not in others).Oracle::DATEtype to the ODBCSQL_TYPE_TIMESTAMP.nanodbccode so that the buffer length argument to theSQLBindParameterAPI call is correctly reported.This last bullet point in particular, is in the codepath used by other drivers, and all other databases so we need to make sure:
All unit tests pass
The nanodbc maintainers don't think that the change is a bad idea.
Closes #962 #959