Fix error and/or r-crash when lengths(params) are different #984
+38
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r2evans
changed the title
hadley
reviewed
Jan 16, 2026
R/dbi-result.R
Outdated
| lens <- lengths(params[!paramDfs]) | ||
| maxlen <- max(lens) | ||
| if (!all(lens %in% c(maxlen, 1L))) { | ||
| cli::cli_abort("When sending multiple parameters, all must be the same length or length 1") |
Member
There was a problem hiding this comment.
odbc already implicitly depends on vctrs via blob and hms, so I think we could make an explicit dependency, and then you could do:
params[!paramDfs] <- vctrs::vec_common_recycle(!!!params[!paramDfs], .arg = "params")And that will handle both the error message and the recycling.
hadley
reviewed
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.