[kubectl-plugin][Refactor] Standardize namespace resolution to respect kubeconfig context.

[kash2104]

Why are these changes needed?

Currently kubectl-plugin failed to respect the kubeconfig context by hardcoding the namespace value to default.

This PR uses Factory's namespace resolution in order to use namespace configured in kubeconfig.

Related issue number

Closes #4318

Checks

• I've made sure the tests are passing.
• Testing Strategy
  • Unit tests
  • Manual tests
  • This PR is not tested :(

[cursor]

Config file namespace ignored due to always-set options.namespace

High Severity

The resolveNamespace() function can no longer use the namespace from a config file. Previously, cmd.Flags().GetString("namespace") returned an empty string when the user didn't pass --namespace, allowing the config file namespace to be used. Now, ToRawKubeConfigLoader().Namespace() always returns a value (at minimum "default"), so options.namespace is never empty. This causes the condition if options.namespace != "" to always be true, making the else if branch that uses rayClusterConfig.Namespace unreachable. Additionally, the error check at line 249 will now incorrectly fail when a config file specifies a namespace different from the kubeconfig default.

Additional Locations (2)

• kubectl-plugin/pkg/cmd/create/create_cluster.go#L152-L157
• kubectl-plugin/pkg/cmd/create/create_cluster.go#L248-L251

 

[400Ping]

Agree, and I think you should add test to check this

[Future-Outlier]

cc @win5923 @lorriexingfang @AndySung320 @400Ping to review

[kash2104]

Currently working on resolving the failing tests.

[win5923]

CI keeps failing. Could you take a look?
https://github.com/ray-project/kuberay/actions/runs/21089666265/job/60659060831?pr=4367

[kash2104]

I tried but the CI that is failing is TestCompleteFoo from session_test.go where it keeps saying that old-context is not found and hence not taking the namespace and the context from it.

Would appreciate help for debugging and passing this test.

[AndySung320]

Hi @kash2104 ,
in your new test, you're trying to use cmd.Flags().Set() but those flags don't exist anymore since you refactored to use Factory's namespace resolution.
Comparing with the old test (which directly set fakeSessionOptions.namespace), the new approach needs to properly configure ConfigFlags so the Factory can read from it.
You need to:

1. Set ConfigFlags.Namespace and ConfigFlags.Context directly as pointers (not via cmd.Flags().Set())
2. Move cmdFactory creation inside the test loop so each test case gets its own configured ConfigFlags
3. Fix the kubeconfig: your contexts reference non-existent clusters, and "old-context" isn't defined in the contexts map

[cursor]

Cursor Bugbot has reviewed your changes and found 2 potential issues.

[AndySung320]

It looks like the Go-build-and-test / Lint (pre-commit) check is still failing.
Could you take a look and fix the lint issues?

[kash2104]

@AndySung320 Have fixed the failing tests.

[Future-Outlier]

Should we also change completion.go?

[kash2104]

If we change completion.go, then we need to modify it to include variable of cmdUtil.Factory type in order to just get the namespace from the kubeconfig. All the other flags like ray-cluster needs to be set using cobra command only since they are not included in the kubeconfig. So do we want that approach?