Fix reading order not synced between EPUBNavigatorViewController and EPUBNavigatorViewModel #694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EPUBNavigatorViewModel
…eading-order-config
mickael-menu
approved these changes
Jan 15, 2026
Member
mickael-menu
left a comment
mickael-menu
left a comment
There was a problem hiding this comment.
Nice catch, thank you for sending a fix!
There was a problem hiding this comment.
Pull request overview
This PR fixes a synchronization issue where EPUBNavigatorViewModel was always using publication.readingOrder instead of respecting the custom readingOrder parameter that could be provided to EPUBNavigatorViewController.
Changes:
- Modified
EPUBNavigatorViewModelto accept and store areadingOrderparameter instead of always deriving it from the publication - Updated
EPUBNavigatorViewControllerto pass the resolvedreadingOrderto the view model and reuse it from there
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Sources/Navigator/EPUB/EPUBNavigatorViewModel.swift | Changed readingOrder from computed property to stored property; added parameter to both initializers |
| Sources/Navigator/EPUB/EPUBNavigatorViewController.swift | Passes readingOrder to view model initialization and reuses viewModel.readingOrder instead of recalculating |
| CHANGELOG.md | Added entry documenting the fix for custom reading order support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EPUBNavigatorViewControllerallows providingreadingOrderas an input paramEPUBNavigatorViewModelwas always usingreadingOrderfrom publication model and this fix passesreadingOrderfrom view controller if available, otherwise it would just usereadingOrderfrom publication model as before.