Skip to content

Conversation

@alexander-astrand
Copy link
Contributor

Description

https://regennetwork.atlassian.net/browse/APP-865


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Go to portfolio tab on dashboard and send some credits. Make sure the conformation modal looks as it should.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@gemini-code-assist
Copy link

Summary of Changes

Hello @alexander-astrand, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a display bug within the transaction confirmation modal (APP-865) by enhancing its responsiveness. It introduces styling to correctly wrap long text and URLs, preventing overflow issues. Additionally, a new prop has been added to control the modal's fullscreen behavior on mobile, which has been applied to specific dashboard modals to maintain their intended presentation.

Highlights

  • Modal Content Display Fix: Implemented styling adjustments within TxModal.CardItemValue to ensure proper text wrapping and prevent content overflow, particularly for long values or URLs.
  • Mobile Fullscreen Control: Introduced a new isFullscreenMobile prop to the TxModal component, allowing explicit control over whether the modal should occupy the full screen on mobile devices.
  • Dashboard Modal Configuration: Configured the transaction success and error modals on the 'My Ecocredits' dashboard page to explicitly disable fullscreen mobile behavior using the new isFullscreenMobile prop.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@netlify
Copy link

netlify bot commented Jan 15, 2026

Deploy Preview for terrasos ready!

Name Link
🔨 Latest commit 0846c26
🔍 Latest deploy log https://app.netlify.com/projects/terrasos/deploys/697896fd2059f5000887603f
😎 Deploy Preview https://deploy-preview-2788--terrasos.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix a bug in the send confirmation modal. The changes involve adding CSS properties to handle text overflow for long strings, which is a good improvement for UI robustness. A new prop isFullscreenMobile is also introduced and passed down to the modal components, presumably to control their appearance on mobile devices.

My review has identified a couple of areas for improvement. I've pointed out the use of a deprecated and redundant CSS property for word breaking. I've also found a typing issue where a new prop is being used without being declared in the component's props interface, which would cause a TypeScript error. Please see the detailed comments for suggestions on how to address these points.

@alexander-astrand
Copy link
Contributor Author

@erikalogie @S4mmyb See testing instructions!

@erikalogie
Copy link
Collaborator

erikalogie commented Jan 20, 2026

Just got this error when trying to send credits:
image

Getting the same error message from more than one account

@blushi
Copy link
Member

blushi commented Jan 20, 2026

Just got this error when trying to send credits: image

create a new DAO, the one you are using has outdated authorizations set up
or test with your user account

@erikalogie
Copy link
Collaborator

Just got this error when trying to send credits: image

create a new DAO, the one you are using has outdated authorizations set up or test with your user account

Ah ok, this looks good

@alexander-astrand alexander-astrand force-pushed the feat-APP-865-send-confirmation-popup-looks-messed-up branch from 705f7b0 to bb1288f Compare January 26, 2026 11:15
@alexander-astrand alexander-astrand force-pushed the feat-APP-865-send-confirmation-popup-looks-messed-up branch from bb1288f to 0846c26 Compare January 27, 2026 10:44
@alexander-astrand alexander-astrand merged commit 98f56d3 into dev Jan 27, 2026
9 of 10 checks passed
@alexander-astrand alexander-astrand deleted the feat-APP-865-send-confirmation-popup-looks-messed-up branch January 27, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants