-
Notifications
You must be signed in to change notification settings - Fork 10
fix: APP-865 fix send confirmation modal bug #2788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: APP-865 fix send confirmation modal bug #2788
Conversation
Summary of ChangesHello @alexander-astrand, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a display bug within the transaction confirmation modal (APP-865) by enhancing its responsiveness. It introduces styling to correctly wrap long text and URLs, preventing overflow issues. Additionally, a new prop has been added to control the modal's fullscreen behavior on mobile, which has been applied to specific dashboard modals to maintain their intended presentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Deploy Preview for terrasos ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix a bug in the send confirmation modal. The changes involve adding CSS properties to handle text overflow for long strings, which is a good improvement for UI robustness. A new prop isFullscreenMobile is also introduced and passed down to the modal components, presumably to control their appearance on mobile devices.
My review has identified a couple of areas for improvement. I've pointed out the use of a deprecated and redundant CSS property for word breaking. I've also found a typing issue where a new prop is being used without being declared in the component's props interface, which would cause a TypeScript error. Please see the detailed comments for suggestions on how to address these points.
|
@erikalogie @S4mmyb See testing instructions! |
web-marketplace/src/legacy-pages/Dashboard/MyEcocredits/MyEcocredits.tsx
Outdated
Show resolved
Hide resolved
705f7b0 to
bb1288f
Compare
bb1288f to
0846c26
Compare


Description
https://regennetwork.atlassian.net/browse/APP-865
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...