Removed xlsx and adoc output formats from norm rule tool #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes support for XLSX and AsciiDoc output formats from the normative rules tool, leaving only JSON and HTML formats supported. This simplification reduces dependencies (removing the write_xlsx gem requirement) and maintenance burden by eliminating ~160 lines of output format code and associated test infrastructure.
Key changes:
- Removed XLSX and AsciiDoc output format support from
create_normative_rules.rb - Cleaned up command-line options and validation logic
- Removed all XLSX/AsciiDoc test infrastructure from the Makefile
- Deleted expected test output files for removed formats
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tools/create_normative_rules.rb | Removed write_xlsx dependency, -x/-a command-line options, output_xlsx/output_adoc functions, and commented debug code |
| tests/norm-rule/expected/test-norm-rules.adoc | Deleted expected test output file for AsciiDoc format (270 lines removed) |
| tests/norm-rule/expected/test-norm-rules.xlsx | Deleted expected test output file for XLSX format |
| Makefile | Removed all build, comparison, and update targets for XLSX and AsciiDoc formats |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: James Ball <jameball@qti.qualcomm.com>
james-ball-qualcomm
deleted the
162-remove-support-for-adoc-and-xlsx-output-formats-for-norm-rule-tool
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.