Skip to content

Simple change #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
james-ball-qualcomm merged 1 commit into from
Dec 11, 2025
Merged

Simple change #165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions tests/norm-rule/expected/test-norm-rules.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,26 +192,26 @@ <h2>Chapters</h2>
<td><a href="test.html#norm:clarification-without-text">norm:clarification-without-text</a></td>
</tr>
<tr>
<td>(No clarification text provided)</td>
<td><a href="https://www.github.com/riscv/jfkd/issues/67">Clarification GitHub Issue</a></td>
<td>[CLARIFICATION] (No clarification text available)</td>
<td><a href="https://www.github.com/riscv/jfkd/issues/67">GitHub Issue</a></td>
</tr>
<tr>
<td rowspan=2 id="clarification-with-text">clarification-with-text</td>
<td>also isn't clear enough.</td>
<td><a href="test.html#norm:clarification-with-text">norm:clarification-with-text</a></td>
</tr>
<tr>
<td>This is the optional clarifying text.</td>
<td><a href="https://github.com/riscv/jfkd/issues/67">Clarification GitHub Issue</a></td>
<td>[CLARIFICATION] This is the optional clarifying text.</td>
<td><a href="https://github.com/riscv/jfkd/issues/67">GitHub Issue</a></td>
</tr>
<tr>
<td rowspan=2 id="clarification-with-table">clarification-with-table</td>
<td>also isn't clear enough.</td>
<td><a href="test.html#norm:clarification-with-text">norm:clarification-with-text</a></td>
</tr>
<tr>
<td><table><thead><tr><th>Header1</th><th>Header2</th></tr></thead><tbody><tr><td>R1C1</td><td>R1C2</td></tr><tr><td>R2C1</td><td>R2C2</td></tr></tbody></table><br></td>
<td><a href="https://github.com/riscv/something/issues/67">Clarification GitHub Issue</a></td>
<td>[CLARIFICATION] <table><thead><tr><th>Header1</th><th>Header2</th></tr></thead><tbody><tr><td>R1C1</td><td>R1C2</td></tr><tr><td>R2C1</td><td>R2C2</td></tr></tbody></table><br></td>
<td><a href="https://github.com/riscv/something/issues/67">GitHub Issue</a></td>
</tr>
<tr>
<td rowspan=1 id="cat-colors">cat-colors</td>
Expand Down
6 changes: 3 additions & 3 deletions tools/create_normative_rules.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1162,15 +1162,15 @@ def html_chapter_table(f, table_num, chapter_name, nr_defs, tags, tag_fname2url)
unless nr.clarification_link.nil?
# The clarification text can only exist if the clarification link also exists.
if nr.clarification_text.nil?
text = "(No clarification text provided)"
text = "(No clarification text available)"
else
text = convert_def_text_to_html(nr.clarification_text)
end

link = %Q{<a href="#{nr.clarification_link}">Clarification GitHub Issue</a>}
link = %Q{<a href="#{nr.clarification_link}">GitHub Issue</a>}

f.puts(%Q{ <tr>}) unless first_row
f.puts(%Q{ <td>#{text}</td>})
f.puts(%Q{ <td>[CLARIFICATION] #{text}</td>})
f.puts(%Q{ <td>#{link}</td>})
f.puts(%Q{ </tr>})
first_row = false
Expand Down