-
Notifications
You must be signed in to change notification settings - Fork 244
Add Unratified Zvzip extension instructions #1449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
8a135fc to
ef746cc
Compare
|
Is there a reason the spec is in your personal GitHub fork and not an official RISC-V International repo? Which TG is this under? |
|
Its a fast track extension. Presently the spec is held at that link for convenience. It will be turned into a PR against the ISA manual. |
9bf6b8f to
53bae9b
Compare
nadime15
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not fully reviewed it yet, as I think there are already more than enough comments for now. Once those are addressed, I will continue the review.
In addition, please follow the exact style used in the other vector related files (for example, vext_arith_insts.sail), with focus on alignment, variable naming, and program flow (this includes checking for invalid configurations (such as overlaps) before reading any variables).
f10de1a to
5aca6df
Compare
c08efc7 to
65d34c5
Compare
Spec: riscv/riscv-isa-manual#2529