Update exception documentation for goal cancellation in ServerGoalHandle (backport #3019) #3023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dle (#3019) * Update exception documentation for goal cancellation The documentation for the canceled function is misleading. Previously, the description said: 1. "Only call this if the goal is canceling." and 2. "\throws rclcpp::exceptions::RCLError If the goal is in any state besides executing." This is a contradiction. Experimentally verified that if the goal is executing and this method is called, an error is thrown. This makes the second statement wrong => correct the statement in the documentation. Signed-off-by: Andrei Costinescu <[email protected]> (cherry picked from commit 6397047)
ahcorde
approved these changes
Jan 20, 2026
Contributor
|
Pulls: #3023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation for the canceled function is misleading. Previously, the description said:
This is a contradiction according to the state diagram in the Goal States section of this document: https://design.ros2.org/articles/actions.html
Experimentally verified that if the goal is executing and this method is called, an error is thrown. This makes the second statement wrong => correct the statement in the documentation.
Description
Fixes # (issue)
Is this user-facing behavior change?
Did you use Generative AI?
No
Additional Information
Should I open PRs for the other distributions (humble, jazzy, kilted, etc) where this documentation change has to be made?☺️
This is an automatic backport of pull request #3019 done by Mergify.