-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
Fix SourceFile::normalized_byte_pos
#151455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
|
@rustbot author |
|
Reminder, once the PR becomes ready for a review, use |
14cd5b1 to
d4d3476
Compare
|
The test was failing on aarch64 because it uses a different asm syntax/language, so my However, differences in the precise error output required manual normalization. I suspect we should instead enable this test just for Intel architectures? Otherwise there will no doubt be other syntax/normalization failures on other targets? @rustbot ready |
This comment has been minimized.
This comment has been minimized.
This method was broken by 258ace6, which changed `self.normalized_pos` to use relative offsets however this method continued to compare against an absolute offset. Also adds a regression test for the issue that this method was originally introduced to fix.
d4d3476 to
01290cc
Compare
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
|
Okay, so it was then failing on gcc which again isn't a surprise. So I've reverted the test normalization and restricted it to x86_64 on llvm; however the |
This method was broken by 258ace6, which changed
self.normalized_posto use relative offsets however this method continued to compare against an absolute offset.Also adds a regression test for the issue that this method was originally introduced to fix.
Closes #149568
Fixes regression of #110885
r? cjgillot (as author of the breaking commit)