Treat opaque proxies as pure #25126
Open
Treat opaque proxies as pure #25126
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aims to fix an issue with erased definitions in the presence of `opaque type`s. The expression generated in the test here is:
```scala
{
val $proxy1: test.type{type Foo = Int} =
test.$asInstanceOf[test.type{type Foo = Int}]
val test$_this: ($proxy1 : test.type{type Foo = Int}) = $proxy1
new test$_this.Bar[Int]():test$_this.Bar[Int]
}
```
This is not considered pure due to the creation of `val $proxy1`, an opaque proxy. Specifically the call to `asInstanceOf` is not considered pure.
This updates `TypedTreeInfo#statPurity` to consider all opaque proxies pure, which allows the whole expression to be considered pure.
Closes scala#24990
mrdziuban
force-pushed
the
issue-24990
branch
from
be1ba34 to
1e4c070
Compare
mrdziuban
changed the title
opaque type as pure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24990
This aims to fix an issue with erased definitions in the presence of
opaque types. The expression generated in the test here is:{ val $proxy1: test.type{type Foo = Int} = test.$asInstanceOf[test.type{type Foo = Int}] val test$_this: ($proxy1 : test.type{type Foo = Int}) = $proxy1 new test$_this.Bar[Int]():test$_this.Bar[Int] }This is not considered pure due to the creation of
val $proxy1, an opaque proxy. Specifically the call toasInstanceOfis not considered pure.This updates
TypedTreeInfo#statPurityto consider all opaque proxies pure, which allows the whole expression to be considered pure.