Backport "Cast inline call results to result type, not method type" to 3.8.2#25193
Merged
WojciechMazur merged 2 commits intorelease-3.8.2from Feb 5, 2026
Merged
Backport "Cast inline call results to result type, not method type" to 3.8.2#25193WojciechMazur merged 2 commits intorelease-3.8.2from
WojciechMazur merged 2 commits intorelease-3.8.2from
Conversation
Preserve attachments of literal constant in `42: Unit`. [Cherry-picked 8f7b6b7]
Fixes #25091. When casting inline call results to keep opaque types, we were using the method type as the target. I suspect `widenTermRefExpr` was probably just missing from the original code: we always want to cast to what the method returns, not to the method reference itself. Investigated with @jan-pieter and @bracevac during the Compiler Issue Spree of January 26, 2026. [Cherry-picked 816fc6c]
Base automatically changed from
release-3.8.2_backport-25110
to
release-3.8.2
February 5, 2026 15:43
Contributor
Author
|
No regressions detected in the community build up to release-3.8.2_backport-25135. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #25111 to the 3.8.2-RC2.
PR submitted by the release tooling.
[skip ci]