add && to allow probe to execute correctly #149
Conversation
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
[test-all] |
|
Let's test Testing Farm as GitHub Action [test-all] |
| "exec": { | ||
| "command": [ "/bin/sh", "-i", "-c", | ||
| "MYSQL_PWD=\"$MYSQL_PASSWORD\" mysqladmin -u $MYSQL_USER ping"] | ||
| "MYSQL_PWD=\"$MYSQL_PASSWORD\" && mysqladmin -u $MYSQL_USER ping"] |
There was a problem hiding this comment.
I am not an expert in mariadb, but what about to use export MYSQL_PWD=\"$MYSQL_PASSWORD\" mysqladmin -u $MYSQL_USER ping
There was a problem hiding this comment.
Hey @phracek it has been a while since I originally raised this issue so I don't remember all of the details but the problem is that these are two commands without any delineator between them.
The export changes the scope of the variable but it is still two commands that need some sort of delineator.
I believe doing a command instead of && would also resolve the issue.
There was a problem hiding this comment.
I am sorry, but as far as I know BASH. the row
"MYSQL_PWD=\"$MYSQL_PASSWORD\" mysqladmin -u $MYSQL_USER ping" means that mysqladmin consumes variable MYSQL_PWD
but
"MYSQL_PWD=\"$MYSQL_PASSWORD\" && mysqladmin -u $MYSQL_USER ping" is used for two bashes.
But may be I am wrong.
@hhorak Am I right?
|
[test-all] |
Pull Request validationFailed🔴 Failed or pending statuses:
Success🟢 Review - Reviewed by a member |
|
[test] |
|
[test-all] |
3 participants
Resolves #148