Fix find_modal_text breakage with latest serenity-next #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkxs
changed the title
arqunis
approved these changes
Dec 24, 2025
arqunis
force-pushed
the
fix_find_modal_text
branch
from
c8a28d9 to
495367a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest serenity-next reworked component types, which breaks
poise::modal::find_modal_text. This change refactors the logic to extract InputText data from its new home in Label components vs its old home in ActionRow components.This will need a
cargo update serenityto compile against Cargo.lockFinally, note that SelectMenu components are also a thing now, so there might need to be additional work done to extract user input from those.