closes #5, fixes archives ordering in sidebar#26
Open
Brikky wants to merge 2 commits intosf-wdi-gaia:masterfrom
Brikky:month_order
Open
closes #5, fixes archives ordering in sidebar#26Brikky wants to merge 2 commits intosf-wdi-gaia:masterfrom Brikky:month_order
Brikky wants to merge 2 commits intosf-wdi-gaia:masterfrom
Brikky:month_order
Conversation
|
Will this play nice with #24 ? |
Author
|
Yes, it's just reorganizing the array of Archives in the same method that builds it. |
|
Is the original SQL query not enough? See |
Author
|
Yes, though the ordering is reversed. Looks like that bug didn't actually make its way into the code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5
Sorts the @Archives array before it's sent back by using a multi-value comparison, ensuring archives are correctly sorted by year and month starting from January (or the earliest month with posts.)