fix(HLS): Fix missing DRM variants with preferredKeySystems #9452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we filter HLS variants by decoding info, those not yet loaded will have no DRM info (yet). Because of this, we should consider all variants without DRM info as compatible with any known-DRM variants. When we have the right info later, we should re-check the decoding info. This code path is specific to the preferredKeySystems config, so applications that don't use that config would not experience this bug. Applications or content not using DRM would also not run into this bug. Due to the way CAF processes Shaka's tracks further, Shaka's missing variants can lead to CAF missing entire languages for apps using preferredKeySystems.
Collaborator
|
Incremental code coverage: 100.00% |
avelad
added
type: bug
Member
|
@shaka-bot test |
Collaborator
|
@avelad: Lab tests started with arguments:
|
avelad
requested changes
Dec 2, 2025
Comment on lines
+2846
to
+2853
| const variants = this.streamToVariants_.get(stream) || new Set(); | ||
| for (const variant of variants) { | ||
| variant.decodingInfos = []; | ||
| } | ||
|
|
||
| if (this.manifest_) { | ||
| await this.playerInterface_.filter(this.manifest_); | ||
| } |
Contributor
There was a problem hiding this comment.
This code block is causing load hangs on android-based Cast devices, which can be repro'd by using a fresh top-of-tree build of v4.16.11, and patching this entire PR.
But the load hangs stop if I specifically comment out this block of code.
Member
Author
There was a problem hiding this comment.
If it truly hangs, that means the Promise isn't resolved. I'll need to dig through the individual awaits within this call to find the one that's hanging.
Member
Author
|
I'm going to simplify this as much as possible and avoid making the filtering situation more complex than it already is. |
Member
|
@joeyparrish do you have any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we filter HLS variants by decoding info, those not yet loaded will have no DRM info (yet). Because of this, we should consider all variants without DRM info as compatible with any known-DRM variants. When we have the right info later, we should re-check the decoding info.
This code path is specific to the preferredKeySystems config, so applications that don't use that config would not experience this bug. Applications or content not using DRM would also not run into this bug.
Due to the way CAF processes Shaka's tracks further, Shaka's missing variants can lead to CAF missing entire languages for apps using preferredKeySystems.