Skip to content

fix(cluster): correct proxy tracking in query rules monitoring #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tanji merged 1 commit into from
Jan 11, 2026
+14 −4
Merged

fix(cluster): correct proxy tracking in query rules monitoring #1326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions cluster/cluster.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1880,7 +1880,7 @@ func (cluster *Cluster) CompareSchemaBetweenMasterAndSlave(sl *ServerMonitor) ([
}
}

for tblname, _ := range slTables {
for tblname := range slTables {
_, ok := masterTables[tblname]
if !ok {
if cluster.IsInSchemaIgnore(tblname) {
Expand Down Expand Up @@ -1959,15 +1959,25 @@ func (cluster *Cluster) MonitorQueryRules() {
var myRule config.QueryRule
if clrule, ok := cluster.QueryRules[rule.Id]; ok {
myRule = clrule
duplicates := strings.Split(clrule.Proxies, ",")

// Handle existing proxies list
var proxyIds []string
if clrule.Proxies != "" {
proxyIds = strings.Split(clrule.Proxies, ",")
}

// Check if current proxy already tracked
found := false
for _, prxid := range duplicates {
for _, prxid := range proxyIds {
if prx.Id == prxid {
found = true
break
}
}

if !found {
duplicates = append(duplicates, prx.Id)
proxyIds = append(proxyIds, prx.Id)
myRule.Proxies = strings.Join(proxyIds, ",")
}
} else {
myRule.Id = rule.Id
Expand Down
Loading