-
Notifications
You must be signed in to change notification settings - Fork 254
Refactor legacy command list to module-level frozenset constant #2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Co-authored-by: m1n0 <[email protected]>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot re-apply the change on the updated base brach |
I've re-applied the refactoring on the updated base branch (
All 5 parametrized tests pass. However, I'm unable to force-push the rebased branch due to tool limitations. The commit is ready locally and may need manual push with |
|
* Chore: handle v3 commands in CLI * Update soda-core/src/soda_core/cli/cli.py Co-authored-by: Copilot <[email protected]> * Parametrize legacy v3 command test to cover all commands (#2549) * Initial plan * Parametrize test to cover all 5 legacy v3 commands Co-authored-by: m1n0 <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: m1n0 <[email protected]> * adjusted link * Refactor legacy command list to module-level frozenset constant (#2548) * Initial plan * Refactor: Move legacy_cmds to module-level constant as frozenset Co-authored-by: m1n0 <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: m1n0 <[email protected]> Co-authored-by: Milan Lukac <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * adjusted wording --------- Co-authored-by: Copilot <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: m1n0 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>



legacy_cmdsfrom function to module-level constantLEGACY_V3_COMMANDSprint()statements from updated base branchNote: Changes have been re-applied on top of the updated base branch (
chore/v3-cliat e728ccf) which includes the parametrized test andprint()statement changes.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.