Skip to content

Conversation

@URenko
Copy link
Contributor

@URenko URenko commented Mar 2, 2023

I have cleaned some deprecated request methods.
And then use httpx or reuqests, which has been installed in almost all python environments, if available (they are not required, and will fallback to urllib if neither is present)。

By using httpx/reuqests, we can benefit from:

  • Built-in session management
  • Built-in decoding (e.g. gzip, brotli)
  • Built-in retries
  • HTTP/2 if avaliable

I kept them for maximum compatibility with the original processing (urllib).
And has been tested in each of the 3 environments (through make test and some personal usages).
If necessary, I can add tests for the 3 environments to GitHub action.

@soimort-bot
Copy link
Collaborator

Hello @URenko,
Thanks for the Pull Request. We ❤️ our contributors!
Please wait for one of our human maintainers to review your patches. This may take a few days to weeks. Also, please understand that although your Pull Request may or may not be eventually merged, we value all contributions equally.

祝您健康!

@URenko
Copy link
Contributor Author

URenko commented Mar 2, 2023

By the way, I have found a project named "handle all HTTP(s) using Requests" at https://github.com/soimort/you-get/projects?type=classic .
Do you have plans to deprecate urllib support entirely? If so it could be more elegant, and I'd be glad to help you.

@URenko URenko deleted the branch soimort:develop May 22, 2024 08:16
@URenko URenko closed this May 22, 2024
@URenko URenko deleted the develop branch May 22, 2024 08:16
@URenko URenko restored the develop branch May 22, 2024 08:17
@URenko URenko reopened this May 22, 2024
@URenko
Copy link
Contributor Author

URenko commented May 22, 2024

Rebased to v0.4.1700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants