kokkos-tools: Disable Variorum and SystemTap CMake options

[tpadioleau]

The PR disables the optional find_package(Variorum QUIET) call, The PR disables the Variorum and SystemTap cmake options, this should help fix #377. These options can be later defined as Spack variants with associated dependencies.

@jennfshr

[tldahlgren]

Manually added missing maintainers to Reviewers list and, when couldn't, to the description.

[vlkale]

This is fine from my end. Though Variorium provides many rich capabilities w.r.t. to energy profiling, I don't think Variorium is critical to the core functionality of Kokkos Tools. I agree this should help fix the problem in #377.

[rbberger]

@vlkale Just for understanding, why isn't there a KokkosTools_ENABLE_VARIORIUM?

[vlkale]

@vlkale Just for understanding, why isn't there a KokkosTools_ENABLE_VARIORIUM?

This should be added and I think is low hanging fruit. @tpatki @ethan-puyaubreau
@slabasan

Do you see any obstacles putting it into the Kokkos Tools CMakeLists.txt? Is this embedded in one of Ethan's recent Kokkos Tools draft PRs for Variorium?

[rbberger]

@vlkale if it can get into develop I would prefer that over adding a workaround here and then later removing it again. Specifically since the only kokkos-tools version right now is develop.

[tpadioleau]

@vlkale if it can get into develop I would prefer that over adding a workaround here and then later removing it again. Specifically since the only kokkos-tools version right now is develop.

I drafted a PR kokkos/kokkos-tools#309, actually even if we merge #1844, we will still have the issue of dtrace.

[vlkale]

@vlkale if it can get into develop I would prefer that over adding a workaround here and then later removing it again. Specifically since the only kokkos-tools version right now is develop.

I drafted a PR kokkos/kokkos-tools#309, actually even if we merge #1844, we will still have the issue of dtrace.

Thank you! I think you have gotten good comments there and it looks like that PR should fix this. I'm also noting PR #310 for making BUILD_SHARED_LIBS a CACHE variable.

[tpadioleau]

Thank you! I think you have gotten good comments there and it looks like that PR should fix this. I'm also noting PR #310 for making BUILD_SHARED_LIBS a CACHE variable.

The PR kokkos/kokkos-tools#309 has been merged, I have updated this PR accordingly.

[Copilot]

Pull Request Overview

Disable selected optional KokkosTools CMake options by default in the Spack package to avoid unintended dependencies (e.g., Variorum, SystemTap), aligning with the plan to introduce them later as variants.

• Add explicit CMake defines to OFF for APEX, CALIPER, SYSTEMTAP, VARIORUM, EXAMPLES, SINGLE, and TESTS
• Keep MPI and PAPI toggled via existing variants

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[tldahlgren]

Based on comment threads it looks like this PR is now ready to be merged. If not, let me know.