Skip to content

Improve detecting non-canonical Sparkle bundles in generate_appcast #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zorgiepoo merged 1 commit into from
Jan 10, 2026
+2 −2
Merged

Improve detecting non-canonical Sparkle bundles in generate_appcast #2836

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions generate_appcast/ArchiveItem.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,8 +301,8 @@ class ArchiveItem: CustomStringConvertible {
for case let fileURL as URL in enumerator {
let name = fileURL.lastPathComponent

// Skip Contents/Resources entirely because frameworks shouldn't be in there and we don't want to pay the cost of scanning in there
guard name != "Resources" || fileURL.deletingLastPathComponent().lastPathComponent != "Contents" else {
// Skip Resources in bundles entirely because frameworks shouldn't be in there and we don't want to pay the cost of scanning in there
guard name != "Resources" else {
enumerator.skipDescendants()
continue
}
Expand Down