Skip to content

Remove unnecessary @ConfigurationPropertiesSource #48934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
quaff wants to merge 1 commit into from
Closed

Remove unnecessary @ConfigurationPropertiesSource #48934

quaff wants to merge 1 commit into from

Conversation

@quaff
Copy link
Contributor

@quaff quaff commented Jan 22, 2026 •
edited by philwebb
Loading

The Javadoc said:

this annotation is only required for types located in a different module than the @ConfigurationProperties class that references them.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 22, 2026
@quaff quaff marked this pull request as draft January 22, 2026 09:12
@quaff
Remove unnecessary @ConfigurationPropertiesSource
2f17011 
The Javadoc said:
>> this annotation is only required for types located in a different module than the @ConfigurationProperties class that references them.

Signed-off-by: Yanming Zhou <[email protected]>
@snicoll
Copy link
Member

snicoll commented Jan 22, 2026

Thanks for the PR

This could be a hangover from code moving around/deleted. That being said, I am surprised by the number of files that are affected. We'll have to review this thoroughly.

@quaff quaff marked this pull request as ready for review January 23, 2026 00:47
@wilkinsona wilkinsona self-assigned this Jan 23, 2026
@wilkinsona
Copy link
Member

wilkinsona commented Jan 23, 2026

The changes in spring-boot-micrometer-metrics and spring-boot-web-server are good. I'd like to double-check that Spring Cloud won't be adversely affected by the changes in spring-boot-http-client.

@wilkinsona wilkinsona added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 23, 2026
@wilkinsona wilkinsona added this to the 4.0.x milestone Jan 23, 2026
@wilkinsona wilkinsona mentioned this pull request Jan 23, 2026
Closed
@wilkinsona wilkinsona modified the milestones: 4.0.x, 4.0.3 Jan 23, 2026
wilkinsona pushed a commit that referenced this pull request Jan 23, 2026
@quaff @wilkinsona
Remove unnecessary @ConfigurationPropertiesSource
5733ee7 
Remove @ConfigurationPropertiesSource from classes that reside in
the same module as all referencing @ConfigurationProperties classes.

Signed-off-by: Yanming Zhou <[email protected]>

See gh-48934
@wilkinsona
Copy link
Member

wilkinsona commented Jan 23, 2026

Thanks very much, @quaff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilkinsona wilkinsona wilkinsona approved these changes

Assignees

@wilkinsona wilkinsona

Labels

type: task A general task

Projects

None yet

Milestone

4.0.3

Development

Successfully merging this pull request may close these issues.

4 participants

@quaff @snicoll @wilkinsona @spring-projects-issues