Skip to content

Use a separate GitHub Action to modify Rust dependencies #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mulkieran merged 1 commit into from
Jul 10, 2025
Merged

Use a separate GitHub Action to modify Rust dependencies #3861

mulkieran merged 1 commit into from
Jul 10, 2025

Conversation

@mulkieran
Copy link
Member

@mulkieran mulkieran commented Jun 16, 2025

@mulkieran mulkieran self-assigned this Jun 16, 2025
@mulkieran mulkieran force-pushed the issue_project_755_rust branch 4 times, most recently from 682a10f to e38532b Compare June 16, 2025 18:32
@packit-as-a-service
Copy link

packit-as-a-service bot commented Jun 16, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3861
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

2 similar comments
@packit-as-a-service
Copy link

packit-as-a-service bot commented Jun 16, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3861
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@packit-as-a-service
Copy link

packit-as-a-service bot commented Jun 16, 2025

Congratulations! One of the builds has completed. 🍾

You can install the built RPMs by following these steps:

  • sudo yum install -y dnf-plugins-core on RHEL 8
  • sudo dnf install -y dnf-plugins-core on Fedora
  • dnf copr enable packit/stratis-storage-stratisd-3861
  • And now you can install the packages.

Please note that the RPMs should be used only in a testing environment.

@mulkieran mulkieran force-pushed the issue_project_755_rust branch from e38532b to 73af926 Compare June 16, 2025 19:05
@mulkieran mulkieran moved this to In Progress in 2025June Jun 16, 2025
@mulkieran mulkieran force-pushed the issue_project_755_rust branch 9 times, most recently from 833cad8 to c85e938 Compare June 16, 2025 20:25
@mulkieran
Copy link
Member Author

mulkieran commented Jun 16, 2025

This is working if there are no matching branches. I'm adding matching branch in libblkid-rs and seeing if that causes a change in the behavior.

@mulkieran
Copy link
Member Author

mulkieran commented Jun 16, 2025

Added libblkid-rs matching branch and had an observable success.

@mulkieran mulkieran moved this from In Progress to In Review in 2025June Jun 16, 2025
@mulkieran mulkieran requested a review from jbaublitz June 16, 2025 20:47
@mulkieran mulkieran force-pushed the issue_project_755_rust branch from c85e938 to 95403a0 Compare June 24, 2025 13:07
@mulkieran mulkieran removed this from 2025June Jul 8, 2025
@mulkieran mulkieran moved this to In Review in 2025July Jul 8, 2025
@mulkieran mulkieran moved this from In Review to In Progress in 2025July Jul 10, 2025
@mulkieran mulkieran force-pushed the issue_project_755_rust branch 3 times, most recently from d32bb66 to 0883b58 Compare July 10, 2025 18:59
@mulkieran mulkieran moved this from In Progress to In Review in 2025July Jul 10, 2025
@mulkieran mulkieran changed the title Use 'cargo add' to modify Rust dependencies Use a separate GitHub Action to modify Rust dependencies Jul 10, 2025
@mulkieran mulkieran marked this pull request as ready for review July 10, 2025 19:06
@mulkieran mulkieran requested a review from jbaublitz July 10, 2025 19:06
@mulkieran mulkieran force-pushed the issue_project_755_rust branch from 0883b58 to 1a1f12f Compare July 10, 2025 19:14
@mulkieran
Use a separate GitHub Action to modify Rust dependencies
1a1f12f 
Modify the Rust dependencies only where obviously appropriate.

For a task with only a cron trigger, the dependency modification can never
be appropriate, since it is only a meaningful action for PRs.

Signed-off-by: mulhern <[email protected]>
jbaublitz
jbaublitz approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@jbaublitz jbaublitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question on this one. Does cargo add not modify Cargo.toml if the branch does not exist?

@mulkieran
Copy link
Member Author

mulkieran commented Jul 10, 2025

Just one question on this one. Does cargo add not modify Cargo.toml if the branch does not exist?

There's no change if the branch does not exist.

@mulkieran mulkieran merged commit b022b70 into stratis-storage:master Jul 10, 2025
39 of 40 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in 2025July Jul 10, 2025
@mulkieran mulkieran deleted the issue_project_755_rust branch July 10, 2025 20:48
@mulkieran mulkieran moved this from Done to Done(1) in 2025July Jul 14, 2025
@mulkieran mulkieran moved this from Done(1) to Pending in 2025July Jul 14, 2025
@mulkieran mulkieran moved this from Pending to Done(1) in 2025July Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbaublitz jbaublitz jbaublitz approved these changes

Assignees

@mulkieran mulkieran

Labels

None yet

Projects

No open projects
2025July
Status: Done(1)

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mulkieran @jbaublitz