-
Notifications
You must be signed in to change notification settings - Fork 109
chore(deps): update dependency poetry to v2.3.1 #971
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved 👍
Summary of ChangesHello @talkiq-ops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the poetry pre-commit hook from version 2.2.1 to 2.3.0. This is a breaking change, as poetry 2.3.0 drops support for Python 3.9, which this project still supports. This will cause the pre-commit hook to fail in any environment running Python 3.9. I have added a critical comment suggesting a fix.
.pre-commit-config.yaml
Outdated
| additional_dependencies: | ||
| # renovate: datasource=pypi depName=poetry | ||
| - poetry==2.2.1 | ||
| - poetry==2.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating poetry to version 2.3.0 will break the pre-commit hook for environments using Python 3.9. According to the release notes, poetry 2.3.0 has dropped support for Python 3.9. Since this project supports Python 3.9 (as defined in all pyproject.toml files), this change will cause pre-commit to fail for developers or CI environments running on Python 3.9.
To fix this, you can either:
- Revert this change to keep using
poetry==2.2.1. - Add
language_version: python3.10(or a newer version) to this pre-commit hook definition in.pre-commit-config.yamlto ensure it runs with a compatible Python version.
I'm suggesting reverting for now as it's the simplest fix.
- poetry==2.2.1eac72d0 to
77b2bf7
Compare
77b2bf7 to
36f53d8
Compare
e18eade to
0f6e6a9
Compare
0f6e6a9 to
6ad7232
Compare
This PR contains the following updates:
2.2.1→2.3.1==2.2.1→==2.3.1Note: The
pre-commitmanager in Renovate is not supported by thepre-commitmaintainers or community. Please do not report any problems there, instead create a Discussion in the Renovate repository if you have any questions.Release Notes
python-poetry/poetry (poetry)
v2.3.1Compare Source
Fixed
Docs
v2.3.0Compare Source
Added
pylock.tomlfiles withpoetry-plugin-export(#10677).requires-poetrybefore any other validation (#10593).project.readmewhen runningpoetry check(#10604).poetry cache clearoptional (#10627).--no-cachesolves an issue (#10585).poetry initwhen tryingpoetry newfor an existing directory (#10563).poetry publish --skip-existingfor new Nexus OSS versions (#10603).poetry debug info(#10588).Changed
installer.re-resolvefromtruetofalse(#10622).poetry.utils._compat.metadata, which is sometimes used in plugins, in favor ofimportlib.metadata(#10634).poetry python(#10606).poetry init, only add the readme field in thepyproject.tomlif the readme file exists (#10679).dulwich>=0.25.0(#10674).Fixed
poetry removedid not work for PEP 735 dependency groups withinclude-groupitems (#10587).poetry removecaused danglinginclude-groupreferences in PEP 735 dependency groups (#10590).poetry adddid not work for PEP 735 dependency groups withinclude-groupitems (#10636).poetry-plugin-export(#10667).poetry publishused the metadata of the project instead of the metadata of the build artifact (#10624).poetry env usejust used another Python version instead of failing when the requested version was not supported by the project (#10685).poetry env activatereturned the wrong command fordash(#10696).data-dirandpython.installation-dircould not be set (#10595).virtualenvs.promptcaused an incomprehensible error message (#10648).Docs
~/.netrcfor Poetry credential configuration (#10630).packagesare automatically detected (#10680).poetry-core (
2.3.0)python_full_versionmarkers with pre-release versions were parsed incorrectly (#893).Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Renovate Bot.