Skip to content

Conversation

@khrm
Copy link
Contributor

@khrm khrm commented Jul 7, 2025

This runs our integration tests on microshift/minc.

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Tested your changes locally (if this is a code change)
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user-facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contain the string "action required" if the change requires additional action from users switching to the new release

Release Notes

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 7, 2025
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from khrm after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot requested review from avinal and enarha July 7, 2025 14:35
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 7, 2025
@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

/kind misc

@tekton-robot tekton-robot added the kind/misc Categorizes issue or PR as a miscellaneuous one. label Jul 7, 2025
@khrm khrm force-pushed the microshift branch 3 times, most recently from 39920b3 to 48a7418 Compare July 7, 2025 14:58
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 7, 2025
@khrm khrm force-pushed the microshift branch 8 times, most recently from 56cb9e4 to c97807b Compare July 7, 2025 20:12
@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

/test pull-tekton-results-integration-tests

1 similar comment
@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

/test pull-tekton-results-integration-tests

@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

/test pull-tekton-results-integration-tests

@khrm khrm force-pushed the microshift branch 2 times, most recently from 082fcec to c0f1159 Compare July 7, 2025 21:23
@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

/test pull-tekton-results-integration-tests

@khrm khrm force-pushed the microshift branch 2 times, most recently from 832c523 to 0a05142 Compare July 7, 2025 23:07
@khrm
Copy link
Contributor Author

khrm commented Jul 7, 2025

/hold

Still doing some changes.

@tekton-robot tekton-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2025
@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/test pull-tekton-results-integration-tests

@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/test pull-tekton-results-integration-tests

@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/test pull-tekton-results-integration-tests

@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/test pull-tekton-results-integration-tests

@khrm khrm force-pushed the microshift branch 2 times, most recently from c6c6819 to 3d0348b Compare July 8, 2025 06:22
@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/test pull-tekton-results-integration-tests

I think now, there's no flake. Let's test again. And then cancel the hold.

@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2025
@khrm
Copy link
Contributor Author

khrm commented Jul 8, 2025

/assign @enarha Let's get this merge.

@khrm khrm requested a review from Copilot July 8, 2025 08:57
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enables running the existing integration tests against a MicroShift cluster by parameterizing the E2E scripts and adding a dedicated GitHub Actions workflow.

  • E2E scripts (e2e.sh, 01-install.sh) now support skipping setup, Kind cluster creation, and port-forward steps via environment variables.
  • The install script logs cluster events after waiting for deployments.
  • A new microshift.yaml workflow installs dependencies, spins up MicroShift with minc, and runs the E2E suite in CI.

Reviewed Changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.

File Description
test/e2e/e2e.sh Parameterized setup/teardown, conditional Kind and port-forward steps
test/e2e/01-install.sh Moved KIND_CLUSTER_NAME export, added kubectl get events
.github/workflows/microshift.yaml New CI job for running tests on MicroShift using minc
Comments suppressed due to low confidence (2)

.github/workflows/microshift.yaml:100

  • The workflow invokes yq but does not install it earlier in the job; add a step to install or make yq available.
          curl https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml | yq 'del(.spec.template.spec.containers[]?.securityContext.runAsUser, .spec.template.spec.containers[]?.securityContext.runAsGroup)' > release.yaml

test/e2e/e2e.sh:22

  • There's a stray hyphen on this line that isn't a valid shell statement; consider removing it to avoid script errors.
set -x;

khrm added 2 commits July 8, 2025 14:40
We added SKIP_KIND, SKIP_PORT_FORWARD and SKIP_SETUP to
support running e2e.sh in non kind clusters.
This adds a GitHub Action to run our e2e tests in
minc/microshift.
@afrittoli
Copy link
Member

Thanks @khrm - alongside this, it would be great if you could migrate existing tests to GHA as well, similar to what other projects have done. We need to reduce cost on GKE, so before adding new GHA tests, I would like to see all existing ones on GHA. FYI @vdemeester

@khrm
Copy link
Contributor Author

khrm commented Jul 15, 2025

@afrittoli Yes, we are targeting migrating all prow jobs to GH actions next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/misc Categorizes issue or PR as a miscellaneuous one. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants