-
Notifications
You must be signed in to change notification settings - Fork 86
Run integration tests on microshift/minc #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/kind misc |
39920b3 to
48a7418
Compare
56cb9e4 to
c97807b
Compare
|
/test pull-tekton-results-integration-tests |
1 similar comment
|
/test pull-tekton-results-integration-tests |
|
/test pull-tekton-results-integration-tests |
082fcec to
c0f1159
Compare
|
/test pull-tekton-results-integration-tests |
832c523 to
0a05142
Compare
|
/hold Still doing some changes. |
|
/test pull-tekton-results-integration-tests |
|
/test pull-tekton-results-integration-tests |
|
/test pull-tekton-results-integration-tests |
|
/test pull-tekton-results-integration-tests |
c6c6819 to
3d0348b
Compare
|
/test pull-tekton-results-integration-tests I think now, there's no flake. Let's test again. And then cancel the hold. |
|
/hold cancel |
|
/assign @enarha Let's get this merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enables running the existing integration tests against a MicroShift cluster by parameterizing the E2E scripts and adding a dedicated GitHub Actions workflow.
- E2E scripts (
e2e.sh,01-install.sh) now support skipping setup, Kind cluster creation, and port-forward steps via environment variables. - The install script logs cluster events after waiting for deployments.
- A new
microshift.yamlworkflow installs dependencies, spins up MicroShift withminc, and runs the E2E suite in CI.
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/e2e/e2e.sh | Parameterized setup/teardown, conditional Kind and port-forward steps |
| test/e2e/01-install.sh | Moved KIND_CLUSTER_NAME export, added kubectl get events |
| .github/workflows/microshift.yaml | New CI job for running tests on MicroShift using minc |
Comments suppressed due to low confidence (2)
.github/workflows/microshift.yaml:100
- The workflow invokes
yqbut does not install it earlier in the job; add a step to install or makeyqavailable.
curl https://storage.googleapis.com/tekton-releases/pipeline/latest/release.yaml | yq 'del(.spec.template.spec.containers[]?.securityContext.runAsUser, .spec.template.spec.containers[]?.securityContext.runAsGroup)' > release.yaml
test/e2e/e2e.sh:22
- There's a stray hyphen on this line that isn't a valid shell statement; consider removing it to avoid script errors.
set -x;
We added SKIP_KIND, SKIP_PORT_FORWARD and SKIP_SETUP to support running e2e.sh in non kind clusters.
This adds a GitHub Action to run our e2e tests in minc/microshift.
|
Thanks @khrm - alongside this, it would be great if you could migrate existing tests to GHA as well, similar to what other projects have done. We need to reduce cost on GKE, so before adding new GHA tests, I would like to see all existing ones on GHA. FYI @vdemeester |
|
@afrittoli Yes, we are targeting migrating all prow jobs to GH actions next week. |
This runs our integration tests on microshift/minc.
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you review them:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes