[Sdk-Go] warn users not to register struct methods as workflows#3679
Merged
axfelix merged 3 commits intotemporalio:mainfrom Jul 16, 2025
Merged
[Sdk-Go] warn users not to register struct methods as workflows#3679axfelix merged 3 commits intotemporalio:mainfrom
axfelix merged 3 commits intotemporalio:mainfrom
Conversation
yuandrew
commented
Jul 11, 2025
| @@ -409,6 +409,14 @@ Activities written as struct methods can use shared struct variables, such as: | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
In the paragraph above starting with "In the Temporal Go SDK programming model," (GH won't let me add a comment that high up), I noticed "struct" seems to be punctuated inconsistently, that paragraph alone has struct, Struct, and struct in different sentences. Not sure if that's something we want to make consistent
Quinn-With-Two-Ns
approved these changes
Jul 14, 2025
axfelix
approved these changes
Jul 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is to address temporalio/sdk-go#1986, the team has decided adding a note in the docs is more suitable than adding a warning log in the SDK itself.
Notes to reviewers
Linked work item and closed SDK PR should have all of the context for this