perf(core): Promote Text delimiter flag to property #1109
+24
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinodell
requested changes
Jan 23, 2026
Member
colinodell
left a comment
colinodell
left a comment
There was a problem hiding this comment.
Thanks for working on this!
I think I'd prefer to fully switch to using the new property, though - no getters, setters, or lingering support for the delim property anywhere in the codebase. Would you be open to making those changes?
SilasArche
force-pushed
the
perf/text-delimiter-property
branch
from
28e8c37 to
2caec47
Compare
SilasArche
force-pushed
the
perf/text-delimiter-property
branch
from
2caec47 to
0bbec4a
Compare
Accessing the `delim` flag within the `$data` array on `Text` nodes is a performance bottleneck in the inline parser engine. This change promotes the flag to a first-class public property for faster access. BREAKING CHANGE: The internal `delim` key in the `$data` array has been removed. The `isDelimiter()` and `setDelimiter()` methods have also been removed. Consumers must now directly access the new `public bool $isDelimiter` property on `Text` nodes. Fixes thephpleague#963 "We polish the silver."
SilasArche
force-pushed
the
perf/text-delimiter-property
branch
from
0bbec4a to
efaa0b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #963
Addresses issue #963.
Previously, the
InlineParserEnginechecked$node->data->has('delim')every time it attempted to merge adjacent text nodes. This resulted in frequent array lookups in the hot path of the parser.This commit promotes the delimiter status to a first-class property on the
Textnode. The constructor now strips thedelimkey from the$dataarray and sets the boolean property$isDelimiterinstead.This reduces overhead for text merging operations without changing the public API surface for extension authors who instantiate
Textnodes."We polish the silver." - The Wake Guild