Add default method for getCardReference#243
Open
eileenmcnaughton wants to merge 1 commit intothephpleague:masterfrom
Open
Add default method for getCardReference#243eileenmcnaughton wants to merge 1 commit intothephpleague:masterfrom
eileenmcnaughton wants to merge 1 commit intothephpleague:masterfrom
Conversation
This adds a getCardReference stub method so that functions that interact with Omnipay don't need to know whether the function exists (and can take action based on whether they return a value rather than on method_exists)
eileenmcnaughton
added a commit
to eileenmcnaughton/omnipay
that referenced
this pull request
Jan 11, 2021
barryvdh
pushed a commit
to thephpleague/omnipay
that referenced
this pull request
Jun 1, 2021
Contributor
|
@barryvdh since the docs saying this is always available got merged, was this meant to have been merged as well? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a getCardReference stub method so that functions that interact with Omnipay
don't need to know whether the function exists (and can take action based on whether
they return a value rather than on method_exists)
Note I think if this is merged I will add a note to https://github.com/thephpleague/omnipay