Fix OCSP.verify_response() to check cert_status #14
+84
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, verify_response() only checked response_status (whether the OCSP server processed the request) but not cert_status (whether the certificate is actually valid). This meant revoked and unknown certificates silently passed validation. Now raises OCSPCertificateRevokedError for revoked certificates and OCSPCertificateUnknownError for unknown status. Fixes thorgate#13 Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cert_statuscheck toverify_response()method to properly validate certificate validityOCSPCertificateRevokedErrorexception for revoked certificatesOCSPCertificateUnknownErrorexception for unknown certificate statusPreviously,
verify_response()only checkedresponse_status(whether the OCSP server processed the request) but notcert_status(whether the certificate is actually valid). This meant revoked and unknown certificates silently passed validation.Fixes #13
Test plan
pytest pyasice/tests/test_ocsp.py -v- all 7 tests passpytest -v- all 45 tests pass🤖 Generated with Claude Code