Skip to content

Conversation

@janbrasna
Copy link
Contributor

This GitHub Actions workflow runs a matrix of a few select Python and Node versions on several platforms/archs to verify sites build and tests run for PRs and master pushes; with visibility into deprecations and incompatibilities for future versions.

Resolves #863

👓 demo/preview: @janbrasna/thunderbird-website /actions/runs/18867825525

@MelissaAutumn
Copy link
Member

This is rad, thanks! Could we switch the build-site to run off of ubuntu, and add a locale build?

Locale compile fails are generally the biggest problem we have here, so it'd be nice to catch those during dev too! And the compile script (or maybe it's extract) uses gnuutils specific arguments that don't work on mac. (Also are servers are on centos iirc, so it's a little closer to irl)

git clone https://github.com/thunderbird/thunderbird.net-l10n.git libs/locale
l10n_tools/compile.sh

@MelissaAutumn MelissaAutumn self-assigned this Oct 28, 2025
@janbrasna
Copy link
Contributor Author

Yes, I'll try to add Ubuntu at least, just currently facing a weird system_requirements parsing issue that for some reason does not exhibit on darwin, either for some toolcache differences, or os-level filesystem access specifics — so I at least started with one platform running it before discovering the blocker to add more.

I know there are currently some "fatal errors" in the gettext scripts from not having trans trim in all the places, but I guess I could inspect the return codes first to see if I can tell apart the long term failures from just real l10n crashes;) ~ +IIUC the only gnu compat wrinkle in the l10n scripts is the find --printf="%h\n" logging/verbosity for processed files/dirs that I can just edit out running the find directly in the CI (or maybe I can look into making the actual script more compatible with some exec dirname etc. instead?)

@janbrasna
Copy link
Contributor Author

Yeah the whitespace errors return with codes really so I can silence these; but then it won't catch any real issues, and be just a log… (NB: msgfmt is preinstalled on darwin, but not part of gettext-base on ubuntu, so it's additional 2min+ to apt-install it in flight each run:/…)

I will try to fight the yaml parsing on platforms for a bit, but it either doesn't see the key, or bails on encoding. 🤷

@MelissaAutumn
Copy link
Member

Ah I see, that's pretty odd. Seems like a problem in thunderbird notes. I see thunderbird/thunderbird-notes#70 has already been made, could you create a bug ticket for the system_requirements problem when you have a chance?

Thank you, it's great to see this has already found some blocking bugs for contributors 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Run pytest per PR via github actions

2 participants