-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
chore(android): update kotlin to 2.3.0 #14362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Any breaking changes related to this change? I'm not sure if we can take this pre-14.0.0 |
|
I've tested an existing app (created with 13.0.1.GA and with some existing modules), kitchensink and building a none-kotlin module with it. Didn't see any issue or difference. sorry: pressed the wrong button 😄 |
|
Yeah, we have a loooot of Kotlin-based modules, so I'm a bit curious if that will cause issues on runtime that we may not see now. @prashantsaini1 WDYT? |
|
My ti.mlkit module still works fine (building and running). The starting point for this change was that the ti.stripe module is not 16kb ready and the stripe-android version that supports it can't be compiled with the current Ti SDK. It's currently being tested on Slack. |
|
Acknowledged. I'll do the required research and update soon. |
|
Here's my current analysis. The Gradle dependency graph shows that the:
It is already safe to directly go to Edit: The Gradle and AGP are already in supported sync with the Kotlin 2.3.0. |
|
I've also tested it with 2.3.0 in case you want me to use that version. Building modules + using them (mlkit, giphy) and building an app with old kotlin modules still works too. Or we can use 2.0.0 for this PR and once it is merged create a new one for 2.3.0 for a later release so we don't have such a big version jump |
|
As 2.0.0 -> 2.3.0 is also a non-major version bump, I'd actually include it here. We can do a 13.1.0 tomorrow then? |
|
I've one minor feature update for 13.1.0 if this can wait until this weekend? The Android Light/Dark theme support to change at run-time as here. Just saw it, my last update was exactly Jan 6, 2025 … 1 year passed already 😄 |
Update Ti Kotlin version to 2.3.0
Tested with my MLKit module (kotlin based) and it will fix a titanium-stripe (https://github.com/hansemannn/titanium-stripe) build error with the latest version. That is using a higher kotlin version in their strip-android version ("The actual metadata version is 2.1.0, but the compiler version 1.9.0 can read versions up to 2.0.0.").