Conversation
FathimaCSgithub
commented
Jul 7, 2025
sarracen/interpolate/cpu_backend.py
Outdated
| @njit(parallel=True, fastmath=True) | ||
| def _fast_2d_cross_cpu(x_data, y_data, w_data, h_data, weight_function, | ||
| kernel_radius, pixels, x1, x2, y1, y2): | ||
| def _fast_2d_line_cpu(x_data, y_data, w_data, h_data, weight_function, |
Contributor
Author
There was a problem hiding this comment.
Do we need the cpu suffix? It is the only one that has it
Owner
There was a problem hiding this comment.
We can remove the _cpu and just name this _fast_2d_line()
ttricco
requested changes
Jul 7, 2025
sarracen/interpolate/cpu_backend.py
Outdated
| @njit(parallel=True, fastmath=True) | ||
| def _fast_2d_cross_cpu(x_data, y_data, w_data, h_data, weight_function, | ||
| kernel_radius, pixels, x1, x2, y1, y2): | ||
| def _fast_2d_line_cpu(x_data, y_data, w_data, h_data, weight_function, |
Owner
There was a problem hiding this comment.
We can remove the _cpu and just name this _fast_2d_line()
sarracen/interpolate/interpolate.py
Outdated
| .interpolate_2d_line(data[x].to_numpy(), data[y].to_numpy(), | ||
| w_norm, h_data, kernel.w, | ||
| kernel.get_radius(), pixels, xlim[0], | ||
| xlim[1], ylim[0], ylim[1]) |
Owner
There was a problem hiding this comment.
The linter has picked up that lines 774/775 and 781-783 no longer have indentation that line up with the preceding lines. These need to be shifted left 1 space.
ttricco
approved these changes
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the name from 2d_cross to 2d_line