Added APR read options #135
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttricco
requested changes
Nov 19, 2025
Owner
ttricco
left a comment
ttricco
left a comment
There was a problem hiding this comment.
Take a look at the failed lint checks under flake8.
Owner
|
As dicussed, I am going to close this PR. Instead of adding APR .ev reading inside read_phantom(), we will add a general purpose standalone function for reading all types of .ev files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following previous PR, the format for APR tracking files has changed. I've added a small section that will read these files (if they exist) and output a df that contains the information that would be needed for plotting.
This routine went into read_phantom.py because it required the dump filename (this is safer than using the time in the simulation). By producing a df with the position and size of the APR region, the user can choose exactly how it is plotted. This also circumvents the rotation problem; both sdf_sinks and sdf_apr will require rotation to be taken into account somehow but both can be treated the same when that is done. Naturally allows for multiple APR regions.
I'll edit the documentation to include an example if you're happy with the above changes.