Skip to content

Add recentre_on_sinks method to SarracenDataFrame class definition#98

Closed
vasu-prasad wants to merge 4 commits intottricco:mainfrom
vasu-prasad:main
Closed

Add recentre_on_sinks method to SarracenDataFrame class definition#98
vasu-prasad wants to merge 4 commits intottricco:mainfrom
vasu-prasad:main

Conversation

@vasu-prasad
Copy link
Contributor

Added a method to sarracen_dataframe.py that moves the data's coordinate origin to a specified sink particle for multi-sink datasets.

@vasu-prasad vasu-prasad marked this pull request as ready for review January 13, 2025 15:17
@ttricco
Copy link
Owner

ttricco commented Jun 4, 2025

I'm going to close this PR based on our discussed this week at 2nd European Phantom Workshop.

If re-centreing all particles around a sink, here is an minimal example of how it could be done (for sink 0):

sdf[['x', 'y', 'z']] += sdf_sinks[['x', 'y', 'z']].loc[0]

@ttricco ttricco closed this Jun 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants