Skip to content

Conversation

@angshumankishore
Copy link

Description

Motivation & Context

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

@coliff
Copy link
Contributor

coliff commented Jan 21, 2026

this PR isn't right... we wouldn't want to remove this part:

"...so we use our own via Sass. This means that customizing our theme colors via CSS variables may cause color contrast issues with these utilities."

@julien-deramond julien-deramond self-requested a review January 21, 2026 07:00
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed with @coliff. The final modification could be only:

- There’s currently no support for a CSS-native `color-contrast` function[...]
+ There’s currently limited support for the `contrast-color` function[...]

Please also remove the extra break lines (see "Files changed" tab).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants