fix(tiptap): use named CodeBlock import to avoid runtime extend error for CodeBlockLowlight extension
#7370
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeBlockLowlight expects CodeBlock to expose `.extend()`, but default imports can resolve to a module wrapper in some ESM/CJS environments, causing `extend is not a function` at runtime. Switching to a named import ensures the actual CodeBlock extension is used and fixes the crash.
🦋 Changeset detectedLatest commit: 5ce3006 The changes in this PR will be included in the next version bump. This PR includes changesets to release 71 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a runtime error in CodeBlockLowlight where calling .extend() would fail in certain ESM/CJS environments. The fix changes the import statement for CodeBlock from a default import to a named import, aligning with the pattern used in other packages like starter-kit.
Key Changes
- Changed
CodeBlockimport from default to named export to ensure proper extension behavior across different module systems
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1 task
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Overview
Fixed a runtime error when initializing
CodeBlockLowlightby switching theCodeBlockimport to a named export. This preventsextend is not a functionerrors caused by ESM/CJS interop issues.Implementation Approach
Replaced the default import of
CodeBlockfrom@tiptap/extension-code-blockwith a named import to ensure the actual extension instance is used. No behavioral changes were introduced beyond the fix.Testing Done
CodeBlockLowlightworks as expectedVerification Steps
Additional Notes
This issue occurs in certain ESM/CJS environments (e.g. Jest, SSR, or specific bundler configurations) where default imports may resolve to a module wrapper instead of the extension itself.
Checklist
Related Issues
Fixes #6703
Fixes #7092