-
Notifications
You must be signed in to change notification settings - Fork 93
feat(themes): add fluorite theme #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(themes): add fluorite theme #134
Conversation
Add the Fluorite theme with elegant purple and pink tones. Soft and sophisticated color scheme inspired by the mineral fluorite. Created by Rnbsov (https://github.com/Rnbsov/fluorite-theme)"
📝 WalkthroughWalkthroughAdded a new built-in dark theme "fluorite": docs updated, a new theme module implemented and re-exported, and the theme loader updated to recognize and list "fluorite". Changes
Sequence Diagram(s)(omitted — changes are localized theme addition without multi-component sequential flow) Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧹 Recent nitpick comments
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🧬 Code graph analysis (1)src/theme/mod.rs (1)
🔇 Additional comments (2)
✏️ Tip: You can disable this entire section by setting Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/theme/mod.rs (1)
92-92: Update error message to include "fluorite".The error message listing available themes doesn't include the newly added "fluorite" theme.
📝 Proposed fix
- .context("Available themes: ayu-dark, catppuccin, dracula, everforest, github-dark, gruvbox, material, monokai, night-owl, nord, one-dark, rose-pine, solarized-dark, solarized-light, telemetry, tokyo-night"), + .context("Available themes: ayu-dark, catppuccin, dracula, everforest, fluorite, github-dark, gruvbox, material, monokai, night-owl, nord, one-dark, rose-pine, solarized-dark, solarized-light, telemetry, tokyo-night"),
🤖 Fix all issues with AI agents
In @src/theme/mod.rs:
- Line 109: The compilation fails because a trailing comma is missing after the
string literal "fluorite" in src/theme/mod.rs; locate the list/array or match
arm that contains the "fluorite" entry (search for the literal "fluorite" in
mod.rs) and add a comma immediately after "fluorite" to correctly separate items
and fix the syntax error.
🧹 Nitpick comments (3)
src/theme/mod.rs (1)
77-77: Consider maintaining alphabetical order.The theme name "fluorite" is placed between "dracula" and "everforest", but alphabetically "everforest" should come before "fluorite" (e < f).
♻️ Suggested reordering
"dracula" => Ok(themes::dracula()), - "fluorite" => Ok(themes::fluorite()), "everforest" => Ok(themes::everforest()), + "fluorite" => Ok(themes::fluorite()), "github-dark" => Ok(themes::github_dark()),src/theme/themes/fluorite.rs (2)
1-6: Fix spacing in import statement.Line 2 has an extra space in the import:
style:: Colorshould bestyle::Color.♻️ Proposed fix
-use ratatui::style:: Color; +use ratatui::style::Color;
12-54: Consider consistent spacing for better readability.Some fields have inconsistent spacing before
Color::Rgb(one space vs. two spaces). For example, lines 12, 26, 30, 43, 49-51, and 54 have two spaces while others have one.♻️ Suggested formatting fix
- editor_line_number: Color::Rgb(42, 28, 54), + editor_line_number: Color::Rgb(42, 28, 54), editor_line_number_cursor: Color::Rgb(65, 43, 84), editor_separator: Color::Rgb(42, 28, 54),Apply similar fixes to lines 26, 30, 43, 49, 50, 51, and 54.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/themes.mdsrc/theme/mod.rssrc/theme/themes/fluorite.rssrc/theme/themes/mod.rs
🧰 Additional context used
🧬 Code graph analysis (2)
src/theme/themes/mod.rs (1)
src/theme/themes/fluorite.rs (1)
fluorite(7-57)
src/theme/mod.rs (1)
src/theme/themes/fluorite.rs (1)
fluorite(7-57)
🔇 Additional comments (3)
docs/themes.md (1)
25-25: LGTM! Documentation entry is clear and consistent.The fluorite theme documentation follows the same format as other themes and is alphabetically positioned correctly.
src/theme/themes/mod.rs (1)
5-5: LGTM! Module registration follows the established pattern.The module declaration and re-export are consistent with other theme modules in the codebase.
Also applies to: 23-23
src/theme/themes/fluorite.rs (1)
7-57: LGTM! Theme implementation is complete and correct.All required Theme fields are present with valid RGB color values. The color palette creates a cohesive fluorite-inspired theme with purple and pink tones.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/theme/mod.rs (1)
92-92: Update error message to include "fluorite".The error context lists all available themes but doesn't include "fluorite". Users encountering this error for an invalid theme won't know that "fluorite" is now available.
📝 Proposed fix
- .context("Available themes: ayu-dark, catppuccin, dracula, everforest, github-dark, gruvbox, material, monokai, night-owl, nord, one-dark, rose-pine, solarized-dark, solarized-light, telemetry, tokyo-night"), + .context("Available themes: ayu-dark, catppuccin, dracula, fluorite, everforest, github-dark, gruvbox, material, monokai, night-owl, nord, one-dark, rose-pine, solarized-dark, solarized-light, telemetry, tokyo-night"),
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/theme/mod.rs
🧰 Additional context used
🧬 Code graph analysis (1)
src/theme/mod.rs (1)
src/theme/themes/fluorite.rs (1)
fluorite(7-57)
🔇 Additional comments (1)
src/theme/mod.rs (1)
77-77: LGTM! Clean theme integration.The fluorite theme is correctly integrated into both the load method and available themes list, maintaining alphabetical ordering throughout.
Also applies to: 109-109
unhappychoice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the Fluorite theme! 🎉
The purple and pink color scheme looks elegant and well-designed. All necessary files are properly updated and the implementation follows the existing theme structure perfectly.
Hello! Thanks for such awesome
cli, I just wanted to add my theme!Add the Fluorite theme with elegant purple and pink tones. Soft and sophisticated color scheme inspired by the mineral fluorite.
Created by
Rnbsov(https://github.com/Rnbsov/fluorite-theme)"Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.