Invalidate flex fields cache on change #285
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@patsatsia I think is better to invalidate the related cache when this change, not remove the cache completely @saxix |
Contributor
Author
I agree @domdinicola I just pushed this working solution, it seems a bit tricky to invalidate the cache, but working on it currently |
patsatsia
force-pushed
the
bugfix/fieldset-fields-not-updated-after-change
branch
from
c3d86d9 to
b657560
Compare
patsatsia
changed the title
patsatsia
requested review from
arsen-vs,
datamik,
domdinicola,
saxix,
sergey-misuk-valor and
vitali-yanushchyk-valor
Collaborator
|
@patsatsia tests are failing |
patsatsia
force-pushed
the
bugfix/fieldset-fields-not-updated-after-change
branch
from
b657560 to
9f4a10f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #285 +/- ##
===========================================
- Coverage 96.33% 96.33% -0.01%
===========================================
Files 214 214
Lines 7857 7877 +20
Branches 790 793 +3
===========================================
+ Hits 7569 7588 +19
- Misses 159 160 +1
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
saxix
requested changes
Dec 19, 2025
added 4 commits
January 12, 2026 10:59
Add two new methods "invalidate_pattern" and "invalidate_containing"
…ntaining" of CacheManager class
patsatsia
force-pushed
the
bugfix/fieldset-fields-not-updated-after-change
branch
from
54b8328 to
4704221
Compare
…so on field deletion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#289999
Implement new methods for CacheManager class that identifies entries by patern and deletes them all on post save signal of FlexField class (for specific FieldSet)