Skip to content

Conversation

@johniak
Copy link
Contributor

@johniak johniak commented Jan 14, 2026

This PR is not finished due to change Priority from Stefano
AB#294012

@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

❌ Patch coverage is 18.54749% with 729 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.57%. Comparing base (4102423) to head (39167a9).
⚠️ Report is 70 commits behind head on develop.

Files with missing lines Patch % Lines
src/hope/apps/registration_datahub/validators.py 11.49% 154 Missing ⚠️
...apps/registration_datahub/tasks/rdi_xlsx_create.py 0.00% 135 Missing ⚠️
src/hope/apps/dashboard/services.py 18.88% 73 Missing ⚠️
.../hope/apps/registration_datahub/tasks/rdi_merge.py 0.00% 64 Missing ⚠️
...apps/registration_datahub/tasks/rdi_kobo_create.py 0.00% 47 Missing ⚠️
...ope/apps/registration_datahub/tasks/deduplicate.py 47.29% 37 Missing and 2 partials ⚠️
src/hope/apps/program/utils.py 10.81% 33 Missing ⚠️
...gistration_datahub/tasks/rdi_xlsx_people_create.py 0.00% 31 Missing ⚠️
src/hope/apps/core/flex_fields_importer.py 0.00% 30 Missing ⚠️
...ope/apps/payment/services/payment_plan_services.py 57.97% 16 Missing and 13 partials ⚠️
... and 6 more

❌ Your patch check has failed because the patch coverage (18.54%) is below the target coverage (97.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (4102423) and HEAD (39167a9). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (4102423) HEAD (39167a9)
e2e 2 1
unit 2 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #5570       +/-   ##
============================================
- Coverage    88.15%   52.57%   -35.58%     
============================================
  Files          508      510        +2     
  Lines        33771    33994      +223     
  Branches      3574     3575        +1     
============================================
- Hits         29771    17873    -11898     
- Misses        3094    15391    +12297     
+ Partials       906      730      -176     
Flag Coverage Δ
e2e 52.57% <18.54%> (-0.04%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@domdinicola domdinicola added the work in progress Change doesn't need to be reviewed label Jan 15, 2026
@domdinicola domdinicola changed the title Feat/ab#294012 ruff plr0915 too many statements RUFF: Feat/ab#294012 ruff plr0915 too many statements Jan 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work in progress Change doesn't need to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants