chore: Update publishing to maven central #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the publishing configuration to use Maven Central with a new plugin and updated credentials. The changes modernize the Gradle wrapper versions and refactor the publishing setup to use the vanniktech Maven publish plugin.
Key changes:
- Updates Gradle wrapper from version 7.4.2/8.0.2 to 8.13 across multiple modules
- Refactors Maven Central publishing to use the vanniktech plugin instead of custom implementation
- Updates environment variable names for Maven Central credentials
Reviewed Changes
Copilot reviewed 7 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| samples/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to version 8.13 |
| kotlin-preprocessors/src/main/kotlin/com/utopiarise/kotlin/preprocessors/gradle/PreProcessorPlugin.kt | Adds explicit it receiver for lambda configuration |
| kotlin-preprocessors/gradle/wrapper/gradle-wrapper.properties | Updates Gradle wrapper to version 8.13 |
| kotlin-preprocessors/buildSrc/src/main/kotlin/publish/mavencentral/PublishToMavenCentralPlugin.kt | Complete refactor to use vanniktech Maven publish plugin |
| kotlin-preprocessors/buildSrc/build.gradle.kts | Adds vanniktech plugin dependency |
| kotlin-preprocessors/build.gradle.kts | Comments out kotlin-dsl plugin and updates grgit version |
| .github/workflows/publish.yaml | Updates environment variable names for Maven Central credentials |
Files not reviewed (3)
- kotlin-preprocessors/.idea/codeStyles/Project.xml: Language not supported
- kotlin-preprocessors/.idea/gradle.xml: Language not supported
- kotlin-preprocessors/.idea/kotlinc.xml: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/publish.yaml:35
- The environment variable name should match the one used in the plugin code. The plugin expects 'UTOPIA_RISE_MAVEN_CENTRAL_PORTAL_TOKEN_USERNAME' but the workflow uses 'UTOPIA_RISE_MAVEN_CENTRAL_TOKEN_USERNAME'.
UTOPIA_RISE_MAVEN_CENTRAL_TOKEN_USERNAME: ${{ secrets.UTOPIA_RISE_MAVEN_CENTRAL_TOKEN_USERNAME }}
.github/workflows/publish.yaml:36
- The environment variable name should match the one used in the plugin code. The plugin expects 'UTOPIA_RISE_MAVEN_CENTRAL_PORTAL_TOKEN_PASSWORD' but the workflow uses 'UTOPIA_RISE_MAVEN_CENTRAL_TOKEN_PASSWORD'.
UTOPIA_RISE_MAVEN_CENTRAL_TOKEN_PASSWORD: ${{ secrets.UTOPIA_RISE_MAVEN_CENTRAL_TOKEN_PASSWORD }}
piiertho
force-pushed
the
chore/update-publishing-to-maven-central
branch
13 times, most recently
from
fee60bd to
13c76bd
Compare
CedNaru
approved these changes
Aug 7, 2025
chippmann
suggested changes
Aug 8, 2025
| kotlin("jvm") | ||
| `kotlin-dsl` | ||
| id("org.ajoberstar.grgit") version "4.1.0" | ||
| id("org.ajoberstar.grgit") version "4.1.1" |
|
|
||
| dependencies { | ||
| implementation(kotlin("gradle-plugin", version = "1.8.20")) | ||
| implementation(kotlin("gradle-plugin", version = "2.0.21")) |
| dependencies { | ||
| implementation(kotlin("gradle-plugin", version = "1.8.20")) | ||
| implementation(kotlin("gradle-plugin", version = "2.0.21")) | ||
| implementation("com.vanniktech:gradle-maven-publish-plugin:0.32.0") |
| pom { | ||
| name.set("kotlin-preprocessors") | ||
| description.set("Gradle plugin to define preprocessors for kotlin language") | ||
| url.set("https://github.com/utopia-rise/godot-kotlin-jvm.git") |
Contributor
There was a problem hiding this comment.
the url is copy pasted from the kotlin jvm project and should be updated to match this project again
| scm { | ||
| connection.set("scm:git:https://github.com/utopia-rise/kotlin-preprocessors") | ||
| developerConnection.set("scm:git:github.com:utopia-rise/kotlin-preprocessors.git") | ||
| connection.set("scm:git:https://github.com/utopia-rise/godot-kotlin-jvm") |
| @@ -1,13 +1,13 @@ | |||
| import kotlincompile.definitions.SamplesDefinitions | |||
| import kotlincompile.definitions.SamplesBuildConfig | |||
Contributor
There was a problem hiding this comment.
why is this suddenly renamed? which change triggered that?
Member
Author
There was a problem hiding this comment.
That was something forgotten in former update
piiertho
force-pushed
the
chore/update-publishing-to-maven-central
branch
from
13c76bd to
671704e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.