-
Notifications
You must be signed in to change notification settings - Fork 1k
HFE make zero a valid ttl during import mode and data loading #3006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: cjx-zar <[email protected]>
03dfb48 to
bb3c851
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3006 +/- ##
=========================================
Coverage 74.34% 74.34%
=========================================
Files 129 129
Lines 70908 70911 +3
=========================================
+ Hits 52714 52718 +4
+ Misses 18194 18193 -1
🚀 New features to boost your workflow:
|
ranshid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think we should just move the test to hashexpire.tcl
Signed-off-by: cjx-zar <[email protected]>
|
By the way, I'd like to ask a question. |
True. this is somewhat related to: #3001 since in the original implementation it was done as if to ignore these actions from ever being performed. However I agree that if we decide that we will report these keyspace events, we will probably have to report that in the result. |
…-io#3006) The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in `HSETEX` and RDB loading where `expiry > 0` is used to check for an expiration. This is problematic because `0` might be treated as no expiry in `import-mode`, instead of an already expired timestamp, leading to incorrect behavior. --------- Signed-off-by: cjx-zar <[email protected]>
The HFE uses EXPIRY_NONE(-1) for fields without a TTL. A bug exists in
HSETEXand RDB loading whereexpiry > 0is used to check for an expiration. This is problematic because0might be treated as no expiry inimport-mode, instead of an already expired timestamp, leading to incorrect behavior.