Optimize SREM/ZREM/HDEL to pause auto shrink when deleting multiple items #3144
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When ZREM and SREM delete a large number of elements, we can apply the same optimization as ZREMRANGEBY*, which is to temporarily pause the autoshrink of the corresponding hashtable to avoid triggering resize/rehash repeatedly during the deletion process. This theoretically leads to some performance improvements. Furthermore, by only triggering a resize once at the end (i.e., only when `hashtableResumeAutoShrink` is called), we can get the most right resize, preventing further resizes during the resize/rehash process. Signed-off-by: Binbin <[email protected]>
enjoy-binbin
commented
Feb 1, 2026
enjoy-binbin
added
the
run-extra-tests
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## unstable #3144 +/- ##
============================================
+ Coverage 74.85% 74.87% +0.02%
============================================
Files 129 129
Lines 71210 71215 +5
============================================
+ Hits 53302 53322 +20
+ Misses 17908 17893 -15
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
run-extra-tests
dvkashapov
approved these changes
Feb 2, 2026
Member
dvkashapov
left a comment
dvkashapov
left a comment
There was a problem hiding this comment.
Overall LGTM, clean and simple
Co-authored-by: Daniil Kashapov <[email protected]> Signed-off-by: Binbin <[email protected]>
zuiderkwast
reviewed
Feb 2, 2026
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
Signed-off-by: Binbin <[email protected]>
enjoy-binbin
changed the title
zuiderkwast
approved these changes
Feb 3, 2026
Contributor
zuiderkwast
left a comment
zuiderkwast
left a comment
There was a problem hiding this comment.
Yes, this is better, without behavior change.
For release notes, we can say something like "optimize srem/zrem/hdel when deleting multiple items".
enjoy-binbin
changed the title
zuiderkwast
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When ZREM / SREM / HDEL delete a large number of elements, we can apply the same
optimization as ZREMRANGEBY*, which is to temporarily pause the autoshrink of
the corresponding hashtable to avoid triggering resize/rehash repeatedly during
the deletion process.
This theoretically leads to some performance improvements. Furthermore, by only
triggering a resize once at the end (i.e., only when
hashtableResumeAutoShrinkis called), we can get the most right resize, preventing further resizes during
the resize/rehash process.