-
Notifications
You must be signed in to change notification settings - Fork 3.3k
[rollout] feat: Fix partial load problem, Add vlm support for trtllm rollout #5149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SchumiDing
wants to merge
30
commits into
verl-project:main
Choose a base branch
from
SchumiDing:vlm_trtllm_support
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+796
−31
Open
Changes from 13 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
dcaacfe
Fix partial load problem, Add vlm support for trtllm rollout
SchumiDing 0394ab5
Precommit check
SchumiDing 0664ab1
Add check for if the model is vlm in trtllmhttpserver
SchumiDing bf71c9b
Support latest trtllm
SchumiDing f6e58b8
Support for qwen2.5 vl
SchumiDing 7af6917
Add trtllm rollout test script
SchumiDing 94c4eb0
Add test_trtllm_rollout workflow to test trtllm_rollout
SchumiDing 25518fe
Add back mistakenly deleted file
SchumiDing fd007fb
Precommit check
SchumiDing 659ec01
Merge branch 'verl-project:main' into vlm_trtllm_support
SchumiDing 55b55dc
Merge branch 'verl-project:main' into vlm_trtllm_support
SchumiDing e2cc50b
Merge branch 'verl-project:main' into vlm_trtllm_support
SchumiDing ca17f8a
Merge branch 'verl-project:main' into vlm_trtllm_support
SchumiDing 62af0f2
Merge branch 'verl-project:main' into vlm_trtllm_support
SchumiDing 24a6620
Modified to inherit the worker extension class of tensorrt llm
SchumiDing 6f055a2
Modified to inherit the worker extension class of tensorrt llm
SchumiDing d0b1d1d
fix readability problem of multimodal config
SchumiDing 6b021f4
Remove need for multimodal server config
SchumiDing a7faa7b
Add vlm unit test into exisiting trtllm unit test
SchumiDing 8519d36
add e2e script to train qwen2.5-vl with trtllm rollout
SchumiDing 9acdcd6
Merge branch 'verl-project:main' into vlm_trtllm_support
SchumiDing 5a145a5
Change import statement
SchumiDing 3776338
remove reward config in e2e script
SchumiDing 1706e71
When multi modal input for trtllm, decode with special token first
SchumiDing 90837f3
rever typo
SchumiDing 57506e2
revert typo
SchumiDing e193d0d
pre commit check
SchumiDing 81050ce
Fix bugs
SchumiDing 91d8c59
Update
SchumiDing 60dd50b
Update
SchumiDing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| name: test_trtllm_rollout | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - v0.* | ||
| paths: | ||
| - "verl/workers/rollout/trtllm_rollout/**" | ||
| - "tests/workers/rollout/rollout_trtllm/**" | ||
| - ".github/workflows/test_trtllm_rollout.yml" | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - v0.* | ||
| paths: | ||
| - "verl/workers/rollout/trtllm_rollout/**" | ||
| - "tests/workers/rollout/rollout_trtllm/**" | ||
| - ".github/workflows/test_trtllm_rollout.yml" | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| env: | ||
| IMAGE: "verl-ci-cn-beijing.cr.volces.com/verlai/verl:trtllm1.2.0rc6" | ||
| DYNAMIC_RUNNER_ENDPOINT: "https://sd10g3clalm04ug7alq90.apigateway-cn-beijing.volceapi.com/runner" | ||
|
|
||
| jobs: | ||
| setup: | ||
| if: github.repository_owner == 'verl-project' | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| runner-label: ${{ steps.create-runner.outputs.runner-label }} | ||
| mlp-task-id: ${{ steps.create-runner.outputs.mlp-task-id }} | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - id: create-runner | ||
| uses: volcengine/vemlp-github-runner@v1 | ||
| with: | ||
| mode: "create" | ||
| faas-url: "${{ env.DYNAMIC_RUNNER_ENDPOINT }}" | ||
| mlp-image: "${{ env.IMAGE }}" | ||
|
|
||
| test_trtllm_rollout: | ||
| needs: setup | ||
| runs-on: ["${{ needs.setup.outputs.runner-label || 'L20x8' }}"] | ||
| timeout-minutes: 60 | ||
| env: | ||
| HTTP_PROXY: ${{ secrets.PROXY_HTTP }} | ||
| HTTPS_PROXY: ${{ secrets.PROXY_HTTPS }} | ||
| NO_PROXY: "localhost,127.0.0.1,hf-mirror.com" | ||
| HF_ENDPOINT: "https://hf-mirror.com" | ||
| HF_HUB_ENABLE_HF_TRANSFER: "0" | ||
| steps: | ||
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 | ||
| with: | ||
| fetch-depth: 0 | ||
| - name: Install the current repository | ||
| run: | | ||
| pip3 install -r requirements-test.txt | ||
| pip3 install --no-deps -e . | ||
| - name: Run TRT-LLM rollout tests | ||
| run: | | ||
| ray stop --force | ||
| pytest -v -s tests/workers/rollout/rollout_trtllm/test_trtllm_rollout_utils.py | ||
|
|
||
| cleanup: | ||
| runs-on: ubuntu-latest | ||
| needs: [setup, test_trtllm_rollout] | ||
| if: always() | ||
| steps: | ||
| - id: destroy-runner | ||
| uses: volcengine/vemlp-github-runner@v1 | ||
| with: | ||
| mode: "destroy" | ||
| faas-url: "${{ env.DYNAMIC_RUNNER_ENDPOINT }}" | ||
| mlp-task-id: "${{ needs.setup.outputs.mlp-task-id }}" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Copyright 2026 Bytedance Ltd. and/or its affiliates | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.