Skip to content

[rollout] refactor: bucketed transfer utils#5309

Open
pengwu22 wants to merge 6 commits intoverl-project:mainfrom
pengwu22:pw/test-wt-utils
Open

[rollout] refactor: bucketed transfer utils#5309
pengwu22 wants to merge 6 commits intoverl-project:mainfrom
pengwu22:pw/test-wt-utils

Conversation

@pengwu22
Copy link
Collaborator

@pengwu22 pengwu22 commented Feb 13, 2026

What does this PR do?

  • Abstract the current vllm weight update helper out for clear interfaces, and more importantly unittests

Test

For changes that can not be tested by CI (e.g., algorithm implementation, new model support), validate by experiment(s) and show results like training curve plots, evaluation results, etc.

  • Extra unittests covering shm and ipc

Checklist Before Submitting

Important

Please check all the following items before requesting a review, otherwise the reviewer might deprioritize this PR for review.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the weight transfer logic into a new, dedicated module bucketed_weight_transfer.py, improving code organization and testability. However, a critical security vulnerability has been identified in the new bucketed weight transfer mechanism due to insecure deserialization and arbitrary code execution. The use of ZMQ's recv_pyobj (which uses pickle) over a predictable IPC socket path in /tmp/ allows any user on the same host to achieve code execution. This must be addressed by using secure serialization and avoiding the transmission of executable callables. Additionally, two high-severity robustness issues were found: one concerning the reuse of a helper function for shared memory creation to improve error handling, and another regarding the fragility of relying on a hardcoded index for CUDA IPC.

@wuxibin89
Copy link
Collaborator

Hold this PR until #5029 merged.

@pengwu22 pengwu22 changed the title [rollout] test: bucketed transfer utils [rollout] refactor, test: bucketed transfer utils Feb 26, 2026
@pengwu22 pengwu22 changed the title [rollout] refactor, test: bucketed transfer utils [rollout] refactor: bucketed transfer utils Feb 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants