Theme: adding multiple components to theme template #2685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duboisp
requested changes
Dec 16, 2025
components/gc-most-requested/samples/gc-most-requested-highlight.html
Outdated
Show resolved
Hide resolved
Garneauma
force-pushed
the
theme-template
branch
from
3c96a34 to
43448ba
Compare
Garneauma
force-pushed
the
theme-template
branch
from
43448ba to
9e2d4f6
Compare
duboisp
requested changes
Dec 17, 2025
Member
duboisp
left a comment
duboisp
left a comment
There was a problem hiding this comment.
Look amazing, I reviewed all example + all code + quickly explored the implementation feasibility into our MWS.
There is :
- one small addition to do in our documentation.
- Extend the gc service information to include the internal highlighted doormat by using what you did directly inside the theme working example.
Cheers
Garneauma
force-pushed
the
theme-template
branch
from
9e2d4f6 to
5c8738f
Compare
Garneauma
force-pushed
the
theme-template
branch
from
5c8738f to
25e5638
Compare
Garneauma
force-pushed
the
theme-template
branch
from
25e5638 to
4d6598a
Compare
Garneauma
force-pushed
the
theme-template
branch
from
4d6598a to
ca67836
Compare
Garneauma
force-pushed
the
theme-template
branch
from
4d8c252 to
748deaa
Compare
Garneauma
force-pushed
the
theme-template
branch
from
748deaa to
63afa78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes related to WET-607.