-
Notifications
You must be signed in to change notification settings - Fork 140
GC Subway stabilization #2704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
GC Subway stabilization #2704
Conversation
Garneauma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrahimMahadi Bon travail!
Outside of the comments, let's
- change any mention of "GC Subway" to "Subway navigation" instead. In French: "GC métro" -> "Navigation de style métro".
- see if there are any improvements that can be done to the JS and CSS (there might not be any).
fcd9f57 to
37ab9d4
Compare
Garneauma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BrahimMahadi Getting there. Quelques petits changements. Merci!
37ab9d4 to
2edd19f
Compare
2edd19f to
ba4852a
Compare
Garneauma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good after that.
ba4852a to
f03a5a9
Compare
f03a5a9 to
ccf4dee
Compare
ccf4dee to
68a4e38
Compare
68a4e38 to
73bb566
Compare
|
Pre-approved upon successful review. |
Stabilized GC subway feature. Reference JIRA ticket WET-435.