-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat: add mention of possibility of perhaps async in the file() loader #13108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just what we needed! 🫡
|
Oops, forgot that the reference entry for I think @ArmandPhilippot suggested what this needs to look like in the other PR? withastro/astro#14932 (comment) |
|
Yes, we would need to update the type with: to show in the reference that the parser can be async. |
Description (required)
For withastro/astro#14932. The parser function can now be async, which is pretty neat if you want to fetch files every time you parse your .csv (maybe don't do that)