-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Reader: Collapse long comments #25156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 30546 | |
| Version | PR #25156 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 2ea2c53 | |
| Installation URL | 64cs06gkdkve8 |
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 30546 | |
| Version | PR #25156 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 2ea2c53 | |
| Installation URL | 63j7272pon03o |
| contentView.addSubview(overlay) | ||
| overlay.pinEdges([.horizontal, .bottom], to: contentContainerView) | ||
| NSLayoutConstraint.activate([ | ||
| overlay.heightAnchor.constraint(equalToConstant: 70) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this constraint may cause conflicts if the font is super large? Instead of hard-code a height here, would setting the button.contentInsets or the margins between the button and its parent view work?
| @IBOutlet private weak var contentContainerView: UIView! | ||
| @IBOutlet private weak var contentContainerHeightConstraint: NSLayoutConstraint! | ||
|
|
||
| private var showMoreOverlay: ShowMoreOverlay! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: use a lazy var to avoid optional
|
|
||
| override func layoutSubviews() { | ||
| super.layoutSubviews() | ||
| gradientLayer.frame = bounds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick:
| gradientLayer.frame = bounds | |
| gradientLayer.frame = layer.bounds |
|
Oh, sorry I didn't mean to send it for a review yet. Let me fix a couple of things, and re-send it. |
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
6fd7d19 to
99e73ca
Compare
99e73ca to
216532a
Compare
|
I reworked and retested the implementation.
I set maximum supported category size for the button, so it looks acceptable under all conditions.
Made overlay optional. Additional changes:
|
|





Reader will now collapse long comments. You can tap "Show More" to expand.