-
Notifications
You must be signed in to change notification settings - Fork 142
Improve portability of tests & benches #959
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the help! I am still getting errors regarding termios.h: https://gist.github.com/Limeth/f0f1bec46a3b3866af0f2add78ffa691 |
this seems to be an issue with your system headers - libxkbcommon includes |
|
I tried the latest commit, and I am still getting more of the same errors: https://gist.github.com/Limeth/f977626499983fe1d9ba4d94d34f20d8 The only relevant piece of information regarding sys/termios.h I was able to find is this issue. |
8555a3f to
0f66241
Compare
|
@Limeth my bad, I forgot to guard the header too. Fixed, as well as further warnings.
That seems it. Seems strange you do not have this update though. |
|
Appreciate the help, it successfully compiles now. It gave me linker errors about missing symbols for the tests, but considering I don't intend on running the tests anyway, it's not really an issue for me: compilation4.log I also found out I can compile just the static lib with This solves the issue for me. Thank you! |
0f66241 to
e16360c
Compare
Fix #957