Skip to content

Conversation

@wismill
Copy link
Member

@wismill wismill commented Jan 21, 2026

Fix #957

@wismill wismill added this to the 1.14.0 milestone Jan 21, 2026
@wismill wismill added the testing Indicates a need for improvements or additions to testing label Jan 21, 2026
@Limeth
Copy link

Limeth commented Jan 21, 2026

Thanks for the help! I am still getting errors regarding termios.h: https://gist.github.com/Limeth/f0f1bec46a3b3866af0f2add78ffa691

@whot
Copy link
Contributor

whot commented Jan 22, 2026

In file included from ../tools/tools-common.c:30:
/home/limeth/.espressif/tools/xtensa-esp-elf/esp-14.2.0_20251107/xtensa-esp-elf/xtensa-esp-elf/include/termios.h:4:10: fatal error: sys/termios.h: No such file or directory
    4 | #include <sys/termios.h>
      |          ^~~~~~~~~~~~~~~
compilation terminated.

this seems to be an issue with your system headers - libxkbcommon includes termios.h (which exists) but that header includes sys/termios.h which does not. We have no control over that.

@wismill
Copy link
Member Author

wismill commented Jan 22, 2026

Agree with @whot. I added a test on the header to mitigate the issue.

I also fixed the noisy warnings about the message code formatting.

@Limeth could you give it another try?

@Limeth
Copy link

Limeth commented Jan 22, 2026

I tried the latest commit, and I am still getting more of the same errors: https://gist.github.com/Limeth/f977626499983fe1d9ba4d94d34f20d8

The only relevant piece of information regarding sys/termios.h I was able to find is this issue.

@wismill wismill force-pushed the fix-microcontroller branch from 8555a3f to 0f66241 Compare January 22, 2026 13:44
@wismill
Copy link
Member Author

wismill commented Jan 22, 2026

@Limeth my bad, I forgot to guard the header too. Fixed, as well as further warnings.

The only relevant piece of information regarding sys/termios.h I was able to find is this issue.

That seems it. Seems strange you do not have this update though.

@Limeth
Copy link

Limeth commented Jan 22, 2026

Appreciate the help, it successfully compiles now.

It gave me linker errors about missing symbols for the tests, but considering I don't intend on running the tests anyway, it's not really an issue for me: compilation4.log

I also found out I can compile just the static lib with meson compile -C build xkbcommon. This would have skipped the compilation of the other targets, and it seems to work on master, too.

This solves the issue for me. Thank you!

@wismill wismill force-pushed the fix-microcontroller branch from 0f66241 to e16360c Compare January 22, 2026 16:21
@wismill wismill merged commit 37d9cb6 into xkbcommon:master Jan 22, 2026
6 checks passed
@wismill wismill deleted the fix-microcontroller branch January 22, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Indicates a need for improvements or additions to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add the ability to disable tests/benches for cross-compiling

3 participants